Project

General

Profile

Bug #31982

Smart Proxy Container Gateway calls Proxy::Settings.initialize_global_settings

Added by Ewoud Kohl van Wijngaarden 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Category:
Container
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The Smart Proxy Container Gateway plugin calls Proxy::Settings.initialize_global_settings which is not how it should work. That's not supposed to be an API that's used by plugins. I believe load_programmable_settings in the plugin DSL is a better alternative.


Related issues

Related to Katello - Feature #31797: The Container Gateway should validate user settingsNew
Related to Katello - Refactor #31796: Container Gateway should handle using default proxy certs differentlyDuplicate

Associated revisions

Revision a5442d6d (diff)
Added by Ewoud Kohl van Wijngaarden 8 months ago

Fixes #31982 - Correct settings handling

This avoids the initialize_global_settings call which is wrong. That can
have unexpected consequences. Instead, it uses the correct
load_programmable_settings to handle it.

It also ensures all files are readable or errors out. The Pulp endpoint
also needs to be a valid URL.

History

#1 Updated by The Foreman Bot 8 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/smart_proxy_container_gateway/pull/11 added

#2 Updated by Ewoud Kohl van Wijngaarden 8 months ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Ewoud Kohl van Wijngaarden 8 months ago

  • Related to Feature #31797: The Container Gateway should validate user settings added

#4 Updated by Ewoud Kohl van Wijngaarden 8 months ago

  • Related to Refactor #31796: Container Gateway should handle using default proxy certs differently added

#5 Updated by Chris Roberts 8 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.0.0
  • Category set to Container

Also available in: Atom PDF