Use-ntp parameter does not work when provisioning RHEL 7 or CentOS 7
Description of problem:
The 'Kickstart default' and 'ntp' templates accept the 'use-ntp' parameter to support the ability to disable NTP and use CHRONY.
However, the code in both templates is broken. Both templates have this line:
use_ntp = host_param_true?('use-ntp') || (is_fedora && os_major < 16) || (rhel_compatible && os_major <= 7)
However, setting use-ntp=false will never work "because of the default os check. os_major is <=7 which will always match for centos 7/rhel 7", which has been previously identified in the Foreman forum (ref. https://community.theforeman.org/t/use-ntp-parameter-does-not-work-when-provisioning-centos7/15763) and issue tracker (ref. https://projects.theforeman.org/issues/28077).
The suggested fix at the time was not accepted.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Set the host (group) or global boolean parameter use-ntp to false.
2. Open the 'Kickstart default' provisioning template and select Preview.
3. Review %package and %post section relating to ntp.
The ntp package is installed and configured. chrony is not installed.
chrony is used instead of ntp when use-ntp=false
The following working patch for the 'use_ntp = ...' line is:
if host_param_true?('use-ntp') || host_param_false?('use-ntp')
use_ntp = host_param('use-ntp')
use_ntp = (is_fedora && os_major < 16) || (rhel_compatible && os_major <= 7)