Project

General

Profile

Feature #32025

Allow changing props for the mounted components

Added by Ondřej Ezr 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:

Description

We should allow to change values on components rendered through our `render_component` thus our custom webcomponent.

It should listen to changes to its `data-props` attribute and rerender the mounted component.

Associated revisions

Revision 71c10db5 (diff)
Added by Ondřej Ezr 4 months ago

Fixes #32025 - allow changing root Component props

This allows changing the root components props from legacy JS, as simple
components should be able to change value programatically without using
Redux store.

It only makes sense to listen to changes on the element's props
data attribute.

Revision 6d8b2f92 (diff)
Added by Ondřej Ezr 3 months ago

Refs #32025 - fix rerender guard condition

In 71c10db57f we've added a rerender option for HTML mounted components,
but the guard there was accidently reversed, so it only got rendered
twice on first mount, but never rerendered.

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8368 added

#2 Updated by Ondřej Ezr 4 months ago

  • Priority changed from Normal to High

#3 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.5.0 added

#4 Updated by Ondřej Ezr 4 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8399 added

Also available in: Atom PDF