Bug #32026: Saving invalid cloned role ends up with Internal server error - Foreman

Bug #32026

Saving invalid cloned role ends up with Internal server error

Added by Ondřej Ezr about 2 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ondřej Ezr

Category:

Users, Roles and Permissions

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

1934427

Pull request:

https://github.com/theforeman/foreman/pull/8369

Fixed in Releases:

2.4.0

Found in Releases:

2.3.3

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1934427

Description of problem:

Error message displayed when cloning a role without supplying name:
Oops, we're sorry but something went wrong undefined method `id' for nil:NilClass

How reproducible:
always

Steps to Reproduce:
1. In Foreman UI: Administer > Roles
2. Pick a role, select Clone from the dropdown
3. Don't input any information in the form and click Submit

Actual results:
Red box with the aforementioned error

Expected results:
Information about the required field

Additional info:

Related issues

Associated revisions

Revision d5301b08 (diff)
Added by Ondřej Ezr about 2 years ago

Fixes #32026 - cloned role throws error 500 if invalid

In e61362d1a103b4fbd79c838a6bb6f01986ab02a9 we've accidently forgot about the create action, but now
save of invalid role would have end up with 500 error.

This moves to using `cloned_from_id` instead of `@original_role` as
source of the original role id as this information is easier to pass to
the form.

History

#1 Updated by Ondřej Ezr about 2 years ago

Triaged changed from No to Yes
Target version set to 2.4.1
Category set to Users, Roles and Permissions
Subject changed from Saving invalid cloned role ends up with 500. to Saving invalid cloned role ends up with Internal server error