Project

General

Profile

Bug #32078

smart_proxy_dynflow_core is not restarted after re-configuration

Added by Evgeni Golov about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
High
Assignee:
Evgeni Golov
Category:
Foreman modules
Target version:
Foreman - 2.3.5
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/puppet-foreman_proxy/pull/653, https://github.com/theforeman/foreman-installer/pull/662, https://github.com/theforeman/puppet-foreman_proxy/pull/681, https://github.com/theforeman/foreman-installer/pull/688
Fixed in Releases:
Foreman - 2.3.5, Foreman - 2.4.0
Found in Releases:
Foreman - 2.3.3, Foreman - 2.4.0
Red Hat JIRA:

Description

Ohai,

during plugin testing we found out that sp_d_core is not restarted after a re-configuration by the installer, thus still running a wrong config (see https://community.theforeman.org/t/foreman-plugins-2-4-rpm-test-pipeline-1-failed/22742/).

The core (heh) of the problem is that we assumed that A~>B~>C in Puppet means that a change to A also will notify C, but that is not the case. (https://github.com/theforeman/puppet-foreman_proxy/blob/aeb026b6758f5b9752de2b579f931596d6de1311/manifests/plugin/dynflow.pp#L54-L71)

A wrongly configured dynflow_core after an upgrade essentially means no working tasks :(

Associated revisions

Revision 763aba8f (diff)
Added by Evgeni Golov about 2 years ago

Fixes #32078 - explicitly notify dynflow core service on changes

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-foreman_proxy/pull/653 added

#2 Updated by The Foreman Bot about 2 years ago

  • Fixed in Releases 2.5.0 added

#3 Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Target version set to 2.4.0

Right now I'm targeting this at 2.4 but it should also be picked to 2.3.

#4 Updated by Evgeni Golov about 2 years ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/662 added

#6 Updated by Ewoud Kohl van Wijngaarden about 2 years ago

  • Triaged changed from No to Yes
  • Fixed in Releases 2.4.0 added
  • Fixed in Releases deleted (2.5.0)

#7 Updated by Tomer Brisker almost 2 years ago

  • Target version changed from 2.4.0 to 2.3.5

#8 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/puppet-foreman_proxy/pull/681 added

#9 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/688 added

#10 Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Fixed in Releases 2.3.5 added

Also available in: Atom PDF