Bug #32216: Debian bullseye/sid facts are rejected - Foreman

Bug #32216

Debian bullseye/sid facts are rejected

Added by Ewoud Kohl van Wijngaarden about 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ewoud Kohl van Wijngaarden

Category:

Facts

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/8416

Fixed in Releases:

2.4.1, 2.5.0

Found in Releases:

2.4.0

Red Hat JIRA:

Description

When uploading facts from Debian Bullseye (currently testing), the facts are rejected:

# /etc/puppetlabs/puppet/node.rb --push-facts host.example.com
host.example.com: During the fact upload the server responded with: 500 Internal Server Error. Error is ignored and the execution continues.
{
  "error": {"message":"Validation failed: Major version is not a number, Major version Operating System version is required"}
}

Associated revisions

Revision 9068b66d (diff)
Added by Ewoud Kohl van Wijngaarden almost 2 years ago

Fixes #32216 - Handle Debian Bullseye Testing facts

While Bullseye is still testing, it's identified as bullseye/sid:

$ cat /etc/os-release
    PRETTY_NAME="Debian GNU/Linux bullseye/sid" 
    NAME="Debian GNU/Linux" 
    ID=debian
    HOME_URL="https://www.debian.org/" 
    SUPPORT_URL="https://www.debian.org/support" 
    BUG_REPORT_URL="https://bugs.debian.org/"

The same shows up in Facter:

$ facter os
{
      architecture => "amd64",
      distro => {
        codename => "bullseye",
        description => "Debian GNU/Linux bullseye/sid",
        id => "Debian",
        release => {
          full => "bullseye/sid",
          major => "bullseye/sid" 
        }
      },
      family => "Debian",
      hardware => "x86_64",
      name => "Debian",
      release => {
        full => "bullseye/sid",
        major => "bullseye/sid" 
      },
      selinux => {
        enabled => false
      }
    }

This chooses to treat it as version 11 (without a minor). The
description is also updated to handle a blank minor. Initially I used
version 11.0 and that resulted in a description "Debian bullseye/sid.0".