Project

General

Profile

Bug #32221

Use eslint react-hooks rules

Added by Jeremy Lenz almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeremy Lenz
Category:
Tests
Target version:
Katello 4.2.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/9511, https://github.com/Katello/katello/pull/9251
Fixed in Releases:
Katello 4.3.0
Found in Releases:
Red Hat JIRA:

Description

Foreman was enforcing react-hooks rules (rules-of-hooks and exhaustive-deps) but Katello currently is not.

Associated revisions

Revision cd9419ab (diff)
Added by Jeremy Lenz over 1 year ago

Fixes #32221 - use eslint react-hooks rules (#9251)

  • Fixes #32221 - use eslint react-hooks rules
  • Refs #32221 - temporarily remove problematic deps until merge of theforeman/foreman#8699

Revision 0b599584 (diff)
Added by Jeremy Lenz over 1 year ago

Refs #32221 - Add back useEffect dependencies (#9511)

(cherry picked from commit 9069b0418b0c3fa744a0ae49d2b35cf94e6cd6da)

History

#1 Updated by Jeremy Lenz almost 2 years ago

  • Description updated (diff)
  • Subject changed from Use eslint-plugin-foreman to Use eslint react-hooks rules

#2 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9251 added

#3 Updated by Justin Sherrill almost 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.1.0
  • Category set to Tests

#4 Updated by Jeremy Lenz over 1 year ago

  • Target version changed from Katello 4.1.0 to Katello 4.2.0

#5 Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases Katello 4.3.0 added

#6 Updated by Jeremy Lenz over 1 year ago

  • Status changed from Ready For Testing to Closed

#7 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/9511 added

Also available in: Atom PDF