Project

General

Profile

Feature #32238

Bind systemd socket activation to IPv6

Added by Ewoud Kohl van Wijngaarden 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Packaging
Target version:
2.4.1
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8433, https://github.com/theforeman/foreman/pull/8432, https://github.com/theforeman/foreman/pull/8421
Fixed in Releases:
2.4.1, 2.5.0
Found in Releases:

Description

By default foreman.socket binds to IPv4 only. This was done to make matching it in Puma easier, but it's not really what should be done in 2021 where everything should be dual stack by default.

In #31431 the need for this matching in Puma was removed which makes it much more flexible. The default should be updated.

Note that the installer currently always overrides it so it's not really a difference for most, but I want to modify the installer to rely on the default.

Given that this is not used by default, I'm setting this as a target for 2.4.1. It can't be picked to an earlier release since #31431 was merged in 2.4.0. This really is fixing something that should have been part of it.

Related issues

Related to Foreman - Feature #29144: Run Puma using systemd socket activationClosed
Related to Foreman - Feature #31431: Use Puma 5.1's feature to synthesize systemd socket bindsClosed

Associated revisions

Revision 3347fa49 (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Fixes #32238 - Bind systemd socket to IPv6

By default foreman.socket binds to IPv4 only. This was done to make
matching it in Puma easier, but it's not really what should be done in
2021 where everything should be dual stack by default.

In aecc3187253ada61a311b5229d215452bd6d67b7 the need for this matching
in Puma was removed which makes it much more flexible. The default
should be updated.

Note that the installer currently always overrides it so it's not really
a difference for most, but I want to modify the installer to rely on the
default.

History

#1 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Related to Feature #29144: Run Puma using systemd socket activation added

#2 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Related to Feature #31431: Use Puma 5.1's feature to synthesize systemd socket binds added

#3 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8421 added

#4 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 2.5.0 added

#5 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8432 added

#7 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8433 added

#8 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 2.4.1 added

Also available in: Atom PDF