Project

General

Profile

Bug #32266

wrong number of arguments (given 1, expected 2) on user-data endpoint

Added by Harm Endres 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Low
Category:
Templates
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:

Description

Hey folks,

we have an issue using the /userdata/user-data endpoint wiht Foreman 2.4.0.

2021-04-07T13:36:26 [I|app|a4ffbe46] Backtrace for 'wrong number of arguments (given 1, expected 2)' error (ArgumentError): wrong number of arguments (given 1, expected 2)
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/controllers/concerns/foreman/controller/template_rendering.rb:28:in `render_error'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/controllers/userdata_controller.rb:40:in `render_userdata_template'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/controllers/userdata_controller.rb:14:in `userdata'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/abstract_controller/base.rb:195:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/rendering.rb:30:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:112:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/controllers/concerns/foreman/controller/timezone.rb:10:in `set_timezone'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:121:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:121:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:121:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/audited-4.10.0/lib/audited/sweeper.rb:14:in `around'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:121:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/audited-4.10.0/lib/audited/sweeper.rb:14:in `around'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:121:in `block in run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:139:in `run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/abstract_controller/callbacks.rb:41:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/rescue.rb:22:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/instrumentation.rb:33:in `block in process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/notifications.rb:180:in `block in instrument'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/notifications.rb:180:in `instrument'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activerecord-6.0.3.5/lib/active_record/railties/controller_runtime.rb:27:in `process_action'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/abstract_controller/base.rb:136:in `process'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionview-6.0.3.5/lib/action_view/rendering.rb:39:in `process'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal.rb:190:in `dispatch'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_controller/metal.rb:254:in `dispatch'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/routing/route_set.rb:33:in `serve'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/journey/router.rb:49:in `block in serve'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/journey/router.rb:32:in `each'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/journey/router.rb:32:in `serve'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/routing/route_set.rb:834:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/apipie-dsl-2.3.0/lib/apipie_dsl/static_dispatcher.rb:67:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.5.18/lib/apipie/static_dispatcher.rb:66:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.5.18/lib/apipie/extractor/recorder.rb:137:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/lib/foreman/middleware/telemetry.rb:10:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.5.18/lib/apipie/middleware/checksum_in_headers.rb:27:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/lib/foreman/middleware/catch_json_parse_errors.rb:9:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/tempfile_reaper.rb:15:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/etag.rb:27:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/conditional_get.rb:27:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/head.rb:12:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/http/content_security_policy.rb:18:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/lib/foreman/middleware/logging_context_session.rb:22:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:266:in `context'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:260:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/cookies.rb:648:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/callbacks.rb:101:in `run_callbacks'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/railties-6.0.3.5/lib/rails/rack/logger.rb:37:in `call_app'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/railties-6.0.3.5/lib/rails/rack/logger.rb:28:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/sprockets-rails-3.2.2/lib/sprockets/rails/quiet_assets.rb:13:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/lib/foreman/middleware/logging_context_request.rb:11:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/request_id.rb:27:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/method_override.rb:24:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/runtime.rb:22:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/activesupport-6.0.3.5/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/executor.rb:14:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/static.rb:126:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/sendfile.rb:110:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/actionpack-6.0.3.5/lib/action_dispatch/middleware/host_authorization.rb:76:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/secure_headers-6.3.2/lib/secure_headers/middleware.rb:11:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/railties-6.0.3.5/lib/rails/engine.rb:527:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/railties-6.0.3.5/lib/rails/railtie.rb:190:in `public_send'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/railties-6.0.3.5/lib/rails/railtie.rb:190:in `method_missing'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/urlmap.rb:74:in `block in call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/urlmap.rb:58:in `each'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/rack-2.2.3/lib/rack/urlmap.rb:58:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/configuration.rb:248:in `call'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/request.rb:76:in `block in handle_request'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/thread_pool.rb:337:in `with_force_shutdown'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/request.rb:75:in `handle_request'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/server.rb:431:in `process_client'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/puma-5.2.2/lib/puma/thread_pool.rb:145:in `block in spawn_thread'
 a4ffbe467d4224c6177f20c4e042879b | /home/foreman/vendor/ruby/2.7.0/gems/logging-2.3.0/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'
2021-04-07T13:36:26 [I|app|a4ffbe46] Completed 500 Internal Server Error in 95ms (ActiveRecord: 56.3ms | Allocations: 12112)

Any hints how to debug this issue?

Thank you in advance
Harm

Associated revisions

Revision e97aec2b (diff)
Added by Lukáš Zapletal 5 months ago

Fixes #32266 - render_error call in userdata fixed (#8442)

History

#1 Updated by Harm Endres 5 months ago

It appears that the client IP is not being transmitted properly. When a user-data template is assigned to the smart proxy, the client gets the configuration from the proxy itself.

2021-04-07T13:36:26 [I|app|a4ffbe46] Started GET "/userdata/user-data?url=http%3A%2F%2Fforeman-proxy.example.com%3A8000" for 10.0.0.1 at 2021-04-07 13:36:26 +0000
2021-04-07T13:36:26 [I|app|a4ffbe46] Processing by UserdataController#userdata as TEXT
2021-04-07T13:36:26 [I|app|a4ffbe46]   Parameters: {"url"=>"http://foreman-proxy.example.com:8000", "userdatum"=>{}}
2021-04-07T13:36:26 [W|app|a4ffbe46] wrong number of arguments (given 1, expected 2)

#3 Updated by Harm Endres 5 months ago

I looked in the database, the remote_addr setting seems to have been lost. Is this on purpose?

#4 Updated by Harm Endres 5 months ago

If I understood the "Reverse proxy handling" part correctly, this is intentional?
https://theforeman.org/manuals/2.4/index.html#Upgradewarnings

#5 Updated by Harm Endres 5 months ago

  • Status changed from New to Rejected

Setting :trusted_proxies properly fixed the issue, sorry for the noise.

#6 Updated by Lukas Zapletal 5 months ago

  • Triaged changed from No to Yes
  • Priority changed from Normal to Low
  • Assignee set to Lukas Zapletal
  • Status changed from Rejected to Assigned

Hello, still it is a bug in error rendering. Easy fix. Thanks for the report.

#7 Updated by The Foreman Bot 5 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8442 added

#8 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.5.0 added

#9 Updated by Anonymous 5 months ago

  • Status changed from Ready For Testing to Closed

#10 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8504 added

#11 Updated by Tomer Brisker 5 months ago

  • Category set to Templates

#12 Updated by Tomer Brisker 5 months ago

  • Fixed in Releases 2.4.1 added

Also available in: Atom PDF