Project

General

Profile

Bug #32285

Use public API to update Setting values

Added by Ondřej Ezr over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

In #30354 we've fixed this in tests, but we are updating setting directly in database in http_proxy callback, we should not do so :)

Associated revisions

Revision 4b07d4d9 (diff)
Added by Ondřej Ezr over 1 year ago

Fixes #32285 - use public API to update setting

We are updating setting for content proxy directly in database, but that
blocks efforts in core to migrate all settings into memory.
This would just break tests, as in production settings will be loaded
from database per request anyway, but it is still better to access
Setting through public API.

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9272 added

#2 Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases Katello 4.2.0 added

#3 Updated by Ondřej Ezr over 1 year ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Chris Roberts over 1 year ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.1.0
  • Category set to API

Also available in: Atom PDF