Project

General

Profile

Feature #32286

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Create a new setting definition DSL

Added by Ondřej Ezr 7 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8624, https://github.com/theforeman/foreman/pull/8437
Fixed in Releases:
3.0.0
Found in Releases:

Description

We should drop setting STI and introduce a new way of defining settings.
For plugins and for core alike.

I'd imagine it similar to permissions, just simplier hopefully.

Related issues

Related to Foreman - Bug #33706: SettingRegistry fails on older categories if setting table is not readyClosed
Related to Foreman - Bug #33740: Setting DSL does not use the explicit initial valuesReady For Testing
Blocks Foreman - Refactor #32403: Add custom validations to new setting DSLClosed
Blocks Foreman - Refactor #32408: Use new DSL to define settingsNew

Associated revisions

Revision 074be461 (diff)
Added by Ondřej Ezr 4 months ago

Fixes #32286 - new settings definition DSL

Introduces a new DSL to define settings, so we don't need to define
STI classes for every setting category and we have more control over
settings from the plugins.

Revision efa0e618 (diff)
Added by Ondřej Ezr about 1 month ago

Refs #32286 - setting DSL switch preparation

Removes some unused methods and tests.
This also add collections to the old collection registry to work before we hold them in registry only.

Revision aecd6902 (diff)
Added by Ondřej Ezr about 1 month ago

Refs #32286 - load definition even in migrations

Loads definitions on every start and makes sure the definitions are always loaded.
This makes it possible to work with settings in migrations.
Only values needs the database, so this is safe to do without any check.

History

#1 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8437 added

#2 Updated by Ondřej Ezr 6 months ago

#3 Updated by Ondřej Ezr 6 months ago

#4 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#5 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8470 added

#6 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8625 added

#7 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.0.0 added

#8 Updated by Ondřej Ezr 4 months ago

  • Status changed from Ready For Testing to Closed

#9 Updated by Ondřej Ezr about 1 month ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/8625, https://github.com/theforeman/foreman/pull/8470)

#10 Updated by Ondřej Ezr 6 days ago

  • Related to Bug #33706: SettingRegistry fails on older categories if setting table is not ready added

#11 Updated by Ondřej Ezr 4 days ago

  • Related to Bug #33740: Setting DSL does not use the explicit initial values added

Also available in: Atom PDF