Project

General

Profile

Refactor #32403

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Add custom validations to new setting DSL

Added by Ondřej Ezr 6 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I'd imagine this can be a simple lambda, that gets the setting record as parameter and performs clasical custom validation, or AR Validator class.


Related issues

Related to Foreman - Bug #32925: root_pass setting does not enforce minimum length of 8 characters as the host and hostgroups forms doNew
Blocked by Foreman - Feature #32286: Create a new setting definition DSLClosed
Precedes Foreman - Refactor #32408: Use new DSL to define settingsNew

Associated revisions

Revision 80fb0c21 (diff)
Added by Ondřej Ezr about 1 month ago

Fixes #32403 - Add validations to a setting DSL

Add ability to define validation per Setting through DSL.
It tries to keep similar syntax to rails model validations.

History

#1 Updated by Ondřej Ezr 6 months ago

  • Blocked by Feature #32286: Create a new setting definition DSL added

#2 Updated by Ondřej Ezr 6 months ago

#3 Updated by The Foreman Bot 6 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8470 added

#4 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#5 Updated by Ondřej Ezr 3 months ago

  • Related to Bug #32925: root_pass setting does not enforce minimum length of 8 characters as the host and hostgroups forms do added

#6 Updated by The Foreman Bot about 1 month ago

  • Fixed in Releases 3.2.0 added

#7 Updated by Ondřej Ezr about 1 month ago

  • Fixed in Releases 3.1.0 added
  • Fixed in Releases deleted (3.2.0)

#8 Updated by Ondřej Ezr about 1 month ago

  • Status changed from Ready For Testing to Closed

#9 Updated by Ondřej Ezr about 1 month ago

  • Status changed from Closed to Ready For Testing
  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)

#10 Updated by Ondřej Ezr about 1 month ago

  • Status changed from Ready For Testing to Closed

Mistakingly reopened

Also available in: Atom PDF