Project

General

Profile

Actions
Copy link

Refactor #32403

closed

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Add custom validations to new setting DSL

Added by Ondřej Ezr about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8470
Fixed in Releases:
3.1.0
Found in Releases:
Red Hat JIRA:

Description

I'd imagine this can be a simple lambda, that gets the setting record as parameter and performs clasical custom validation, or AR Validator class.

Related issues 3 (0 open — 3 closed)

Related to Foreman - Bug #32925: root_pass setting does not enforce minimum length of 8 characters as the host and hostgroups forms doClosedActions
Blocked by Foreman - Feature #32286: Create a new setting definition DSLClosedOndřej EzrActions
Precedes Foreman - Refactor #32408: Use new DSL to define settingsClosedOndřej EzrActions
Actions
Copy link
 #1

Updated by Ondřej Ezr about 3 years ago

  • Blocked by Feature #32286: Create a new setting definition DSL added
Actions
Copy link
 #2

Updated by Ondřej Ezr about 3 years ago

Actions
Copy link
 #3

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Ezr
  • Pull request https://github.com/theforeman/foreman/pull/8470 added
Actions
Copy link
 #4

Updated by The Foreman Bot almost 3 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added
Actions
Copy link
 #5

Updated by Ondřej Ezr over 2 years ago

  • Related to Bug #32925: root_pass setting does not enforce minimum length of 8 characters as the host and hostgroups forms do added
Actions
Copy link
 #6

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.2.0 added
Actions
Copy link
 #7

Updated by Ondřej Ezr over 2 years ago

  • Fixed in Releases 3.1.0 added
  • Fixed in Releases deleted (3.2.0)
Actions
Copy link
 #8

Updated by Ondřej Ezr over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #9

Updated by Ondřej Ezr over 2 years ago

  • Status changed from Closed to Ready For Testing
  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)
Actions
Copy link
 #10

Updated by Ondřej Ezr over 2 years ago

  • Status changed from Ready For Testing to Closed

Mistakingly reopened

Actions
Copy link

Also available in: Atom PDF