Refactor #32415
Tracker #29939: Improve setting definition DSL and move setting registry to memory
Use only SettingRegistry to read and update the settings
Pull request:
Fixed in Releases:
Found in Releases:
Description
We are still using the model in the Api::V2::SettingsController.
We want all the methods to go through the SettingRegistry, so we don't need all the Settings to have DB record.
Related issues
Associated revisions
History
#1
Updated by The Foreman Bot about 1 year ago
Updated by - Assignee set to Ondřej Ezr
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8465 added
#2
Updated by Ondřej Ezr about 1 year ago
Updated by - Description updated (diff)
- Subject changed from Use only SettingRegistry to update the settings to Use only SettingRegistry to read and update the settings
#3
Updated by Ondřej Ezr about 1 year ago
- Follows Refactor #32287: Load Setting index page from memory registry added
#4
Updated by The Foreman Bot 10 months ago
- Fixed in Releases 3.0.0 added
#5
Updated by Ondřej Ezr 10 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|3ff1fd27fa32f7a52ecd995417521b5b91c9a093.
Fixes #32415 - access only through SettingRegistry
Update and read the settings through SettingRegistry.
Adds a layer between controller and Model.
SettingRegistry is proxying the value parsing method to the model.
This lifts blocker for settings without DB record.