Project

General

Profile

Refactor #32415

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Use only SettingRegistry to read and update the settings

Added by Ondřej Ezr 6 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We are still using the model in the Api::V2::SettingsController.

We want all the methods to go through the SettingRegistry, so we don't need all the Settings to have DB record.


Related issues

Follows Foreman - Refactor #32287: Load Setting index page from memory registryClosed

Associated revisions

Revision 3ff1fd27 (diff)
Added by Ondřej Ezr 3 months ago

Fixes #32415 - access only through SettingRegistry

Update and read the settings through SettingRegistry.
Adds a layer between controller and Model.
SettingRegistry is proxying the value parsing method to the model.

This lifts blocker for settings without DB record.

History

#1 Updated by The Foreman Bot 6 months ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8465 added

#2 Updated by Ondřej Ezr 6 months ago

  • Description updated (diff)
  • Subject changed from Use only SettingRegistry to update the settings to Use only SettingRegistry to read and update the settings

#3 Updated by Ondřej Ezr 6 months ago

  • Follows Refactor #32287: Load Setting index page from memory registry added

#4 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.0.0 added

#5 Updated by Ondřej Ezr 3 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF