Actions
Bug #32421
closed
hammer export fails with super large chunk size (change chunk-size-mb to gb)
Status:
Closed
Priority:
Normal
Assignee:
Category:
Inter Server Sync
Target version:
Difficulty:
Triaged:
Yes
Description
```
- hammer content-export complete library --organization-title "export-153" --chunk-size-mb 100000000000000
[................................................................................] [100%]
Error: [Errno 32] Broken pipe
undefined method `first' for nil:NilClass
```
Fails while
- hammer content-export complete library --organization-title "export-153" --chunk-size-mb 1000000000000
[................................................................................] [100%]
```
works.
The issue here is that the user may accidentally assume `--chunk-size-mb` and feed unusually large numbers.
We need katello to handle this invalid size error better and fail gracefully.
Updated by Partha Aji almost 3 years ago
Connected to -> https://pulp.plan.io/issues/8628
Updated by Partha Aji almost 3 years ago
Correction "The issue here is that the user may accidentally assume `--chunk-size-mb` is in bytes instead of megabytes"
Updated by James Jeffers almost 3 years ago
Partha, which version should this be targeted to?
Updated by Partha Aji almost 3 years ago
- Target version set to Katello 4.2.0
Lets move it to 4.2. We can error out if the chunk size is > 1 petabyte
Updated by Partha Aji almost 3 years ago
- Target version changed from Katello 4.2.0 to Katello 4.1.0
Proposal
- change --chunk-size-mb to --chunk-size-gb both in api and ui
- Validate the value is >0 and < 1e6
- https://github.com/Katello/katello/blob/master/app/services/katello/pulp3/content_view_version/export.rb#L55
- https://github.com/Katello/katello/blob/master/app/controllers/katello/api/v2/content_exports_controller.rb#L48
- https://github.com/Katello/katello/blob/master/app/controllers/katello/api/v2/content_export_incrementals_controller.rb#L31
- Check on hammer
Updated by Partha Aji almost 3 years ago
- Subject changed from hammer export fails with super large chunk size to hammer export fails with super large chunk size (change chunk-size-mb to gb)
Updated by The Foreman Bot almost 3 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello/pull/9331 added
Updated by The Foreman Bot almost 3 years ago
- Pull request https://github.com/Katello/hammer-cli-katello/pull/803 added
Updated by The Foreman Bot almost 3 years ago
- Fixed in Releases Katello 4.2.0 added
Updated by Lucy Fu almost 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|8bf6159f42a5d74da05c74620a3a897d00ad0916.
Updated by The Foreman Bot almost 3 years ago
- Assignee set to Chris Roberts
- Pull request https://github.com/Katello/hammer-cli-katello/pull/806 added
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/Katello/katello/pull/10108 added
Actions