Project

General

Profile

Bug #32489

Tracker #29939: Improve setting definition DSL and move setting registry to memory

Setting registry doesn't reload properly on autoreload

Added by Tomer Brisker almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8526
Fixed in Releases:
2.5.3, 3.0.0
Found in Releases:
Red Hat JIRA:

Description

When editing code in development that causes rails to reload the application, the registry isn't properly reloaded leading to missing settings and errors

Related issues

Has duplicate Foreman - Bug #33257: Getting /apidoc/v2.json results in a broken Foreman GUI (500 Internal Server Error)Resolved

Associated revisions

Revision 63469bc6 (diff)
Added by Ondřej Ezr almost 2 years ago

Fixes #32489 - setting load on code reload

Code reloading unloads setting descendants and thus
SettingRegistry.reload won't get any definitions of default from them.

This loads the STI classes.

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8526 added

#2 Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.0.0 added

#3 Updated by Ondřej Ezr almost 2 years ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker over 1 year ago

  • Has duplicate Bug #33257: Getting /apidoc/v2.json results in a broken Foreman GUI (500 Internal Server Error) added

#5 Updated by Tomer Brisker over 1 year ago

  • Fixed in Releases 2.5.3 added

Also available in: Atom PDF