Project

General

Profile

Actions
Copy link

Bug #32660

closed

katello assumes GET params in repo url are SLES auth tokens, but may not be

Added by Justin Sherrill over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
James Jeffers
Category:
Repositories
Target version:
Katello 4.2.1
Difficulty:
Triaged:
Yes
Bugzilla link:
1980121
Pull request:
https://github.com/Katello/katello/pull/9596
Fixed in Releases:
Katello 4.3.0
Found in Releases:
Red Hat JIRA:

Description

when trying to sync a mirror repo like:

http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=stock

get params are specified. Katello interprets these as sles auth tokens: https://github.com/Katello/katello/blob/master/app/services/katello/pulp3/repository/yum.rb#L20-L25

but in this case they are not. This doesn't actually cause a problem, as usually they are ignored, except its not exactly 100% correct, and exposed another bug in pulp: https://pulp.plan.io/issues/8816

Actions
Copy link
 #1

Updated by Chris Roberts over 3 years ago

  • Target version set to Katello 4.2.0
  • Triaged changed from No to Yes
Actions
Copy link
 #2

Updated by Justin Sherrill over 3 years ago

  • Bugzilla link set to 1980121
Actions
Copy link
 #3

Updated by Justin Sherrill over 3 years ago

  • Target version changed from Katello 4.2.0 to Katello 4.2.1
Actions
Copy link
 #4

Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to James Jeffers
  • Pull request https://github.com/Katello/katello/pull/9596 added
Actions
Copy link
 #5

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases Katello 4.3.0 added
Actions
Copy link
 #6

Updated by James Jeffers about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF