Project

General

Profile

Bug #32660

katello assumes GET params in repo url are SLES auth tokens, but may not be

Added by Justin Sherrill 12 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
James Jeffers
Category:
Repositories
Target version:
Katello 4.2.1
Difficulty:
Triaged:
Yes
Bugzilla link:
1980121
Pull request:
https://github.com/Katello/katello/pull/9596
Fixed in Releases:
Katello 4.3.0
Found in Releases:
Red Hat JIRA:

Description

when trying to sync a mirror repo like:

http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=stock

get params are specified. Katello interprets these as sles auth tokens: https://github.com/Katello/katello/blob/master/app/services/katello/pulp3/repository/yum.rb#L20-L25

but in this case they are not. This doesn't actually cause a problem, as usually they are ignored, except its not exactly 100% correct, and exposed another bug in pulp: https://pulp.plan.io/issues/8816

Associated revisions

Revision eb616046 (diff)
Added by James Jeffers 8 months ago

Fixes #32660 - adds an authentication token for repository remote URLS such as SLES repos

History

#1 Updated by Chris Roberts 12 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.2.0

#2 Updated by Justin Sherrill 11 months ago

  • Bugzilla link set to 1980121

#3 Updated by Justin Sherrill 9 months ago

  • Target version changed from Katello 4.2.0 to Katello 4.2.1

#4 Updated by The Foreman Bot 9 months ago

  • Assignee set to James Jeffers
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9596 added

#5 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases Katello 4.3.0 added

#6 Updated by James Jeffers 8 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF