Project

General

Custom queries

Profile

Actions
Copy link

Bug #32662

closed

Editing an existing bookmark should respect the current visibility

Added by Nacho Barrientos almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Search
Target version:
2.5.1
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8554
Fixed in Releases:
2.5.1, 3.0.0
Found in Releases:
2.4.0
Red Hat JIRA:

Description

When editing a bookmark, the form does not take into account the current visibility state and shows the Public checkbox always ticked, even if the bookmark being edited is private. This is a bit counterintuitive and could easily lead to erroneously changing the visibility. It'd be nice if Foreman took into account the current visibility instead when rendering the form.

I'll send a patch.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8554 added
Actions
Copy link
 #2

Updated by Tomer Brisker almost 4 years ago

  • Category set to Search
Actions
Copy link
 #3

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 3.0.0 added
Actions
Copy link
 #4

Updated by Nacho Barrientos almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by Tomer Brisker almost 4 years ago

  • Target version set to 2.5.1
Actions
Copy link
 #6

Updated by Tomer Brisker almost 4 years ago

  • Fixed in Releases 2.5.1 added
Actions
Copy link

Also available in: Atom PDF