Bug #32725: katello-change-hostname should handle --no-enable-puppet properly - Packaging - Foreman

Bug #32725

katello-change-hostname should handle --no-enable-puppet properly

Added by Ian Ballou almost 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Ewoud Kohl van Wijngaarden

Category:

RPMs

Target version:

Foreman - 2.5.1

Difficulty:

Triaged:

Bugzilla link:

1967974

Pull request:

https://github.com/theforeman/foreman-packaging/pull/6749, https://github.com/theforeman/foreman-packaging/pull/6774

Fixed in Releases:

Foreman - 2.5.1, Foreman - 3.0.0

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1967974

Description of problem:

katello-change-hostname will error out if @scenario_answers['puppet'] is false (https://github.com/theforeman/foreman-packaging/blob/rpm/1.24/packages/katello/katello/hostname-change.rb#L170). We should skip `delete_puppet_certs` if this is the case.

Version-Release number of selected component (if applicable):

Katello 3.14

How reproducible:

Always

Steps to Reproduce:
1. Remove the puppet configuration from katello-answers.yaml
2. Run katello-change-hostname
3.

Actual results:

deleting old certs
/usr/share/katello/hostname-change.rb:217:in `delete_puppet_certs': undefined method `[]' for nil:NilClass (NoMethodError)
from /usr/share/katello/hostname-change.rb:488:in `run'
from /sbin/katello-change-hostname:23:in `<main>'

Expected results:

hostname changed successfully

Additional info:

Associated revisions

Revision ee14227e (diff)
Added by Ewoud Kohl van Wijngaarden almost 2 years ago

Fixes #32725 - Make delete_puppet_certs handle all input

If a user runs the installer with --no-enable-puppet the value of
@scenario_answers['puppet'] becomes false. false['ssldir'] raises an
exception. By returning early, it's handled safely.

History

#1 Updated by Ian Ballou almost 2 years ago

Subject changed from katello-change-hostname should handle --no-enable-puppet properly to katello-change-hostname should handle --no-enable-puppet properly
Pull request https://github.com/theforeman/foreman-packaging/pull/6749 added