Project

General

Profile

Bug #32752

clicking on a read-only setting still opens an edit dialog

Added by Tomer Brisker 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

when a run-time setting is defined in settings.yaml it becomes read-only in the application.
However when going to the settings page and clicking on the read-only value an edit dialog is still opened.
Attempting to save from the dialog fails with a 500 error, and does not display the error message correctly (which may or may not be a separate issue).

Associated revisions

Revision a3d1c6aa (diff)
Added by Tomer Brisker 4 months ago

Fixes #32752 - Don't allow editing readonly settings (#8608)

  • Fixes #32752 - Don't allow editing readonly settings
  • Refs #32752 - Move setting editing handling into the cell

Instead of having the table handle the modal and passing down the
callback to trigger it, move the editing logic into the inner cell.

  • Refs #32752 - simplify setSettingEditing action

There is no need for the action to be async

  • Refs #32752 - update snapshots
  • Refs #32752 - Explicitly add onClick listener

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8608 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.0.0 added

#3 Updated by Tomer Brisker 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF