Bug #32814: Ansible crashes if working_dir does not exist - Ansible - Foreman

Actions

Copy link

Bug #32814

closed

Ansible crashes if working_dir does not exist

Added by Adam Ruzicka almost 4 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Adi Abramovitch

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/smart_proxy_ansible/pull/52, https://github.com/theforeman/smart_proxy_ansible/pull/53

Fixed in Releases:

smart_proxy_ansible-3.3.0

Found in Releases:

Red Hat JIRA:

Description

2021-06-15T16:50:29 4bbccf26 [E] <Errno::ENOENT> No such file or directory @ dir_s_mkdir - /home/aruzicka/.foreman-ansible/d20210615-74610-jrg7o6      
        $HOME/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/tmpdir.rb:85:in `mkdir'                                                                                                                                                                                                  
        $HOME/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/tmpdir.rb:85:in `block in mktmpdir'                                                                                                                                                                                      
        $HOME/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/tmpdir.rb:129:in `create'                                                                                                                                                                                                
        $HOME/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/tmpdir.rb:83:in `mktmpdir'                                                                                                                                                                                               
        smart-proxy-ansible/lib/smart_proxy_ansible/runner/ansible_runner.rb:190:in `working_dir'                                                                                                                                                          
        smart-proxy-ansible/lib/smart_proxy_ansible/runner/ansible_runner.rb:16:in `initialize'                                                                                                                                                            
        smart-proxy-dynflow/lib/smart_proxy_dynflow/action/batch_runner.rb:11:in `new'                                                                                                                                                                     
        smart-proxy-dynflow/lib/smart_proxy_dynflow/action/batch_runner.rb:11:in `initiate_runner'                                                                                                                                                         
        smart-proxy-dynflow/lib/smart_proxy_dynflow/action/runner.rb:40:in `init_run'                                                                                                                                                                      
        smart-proxy-dynflow/lib/smart_proxy_dynflow/action/runner.rb:10:in `run'

Actions

Copy link

Updated by Adi Abramovitch over 3 years ago

Assignee set to Adi Abramovitch

Actions

Copy link

Updated by The Foreman Bot over 3 years ago

Status changed from New to Ready For Testing
Pull request https://github.com/theforeman/smart_proxy_ansible/pull/50 added

Actions

Copy link

Updated by Ondřej Pražák over 3 years ago

Still reproducible with:

:working_dir: '/tmp/bar/baz/boo'

Actions

Copy link

Updated by Adi Abramovitch over 3 years ago

Pull request deleted (~~https://github.com/theforeman/smart_proxy_ansible/pull/50~~)

Actions

Copy link

Updated by The Foreman Bot over 3 years ago

Pull request https://github.com/theforeman/smart_proxy_ansible/pull/52 added

Actions

Copy link

Updated by Ondřej Ezr over 3 years ago

I don't think we want to fix this.
Would a validation of that setting (if the dir in setting doesn't exist fail to init the proxy) be a proper fix?
Or should we try to create the working directory?

Actions

Copy link