Project

General

Profile

Bug #32843

JS sprintf mock does not correctly handle string interpolation

Added by Tomer Brisker 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Development tools
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

sprintf is mocked to return the same string as it is passed, which is incorrect - it should interpolate the string parameters.

Associated revisions

Revision 2e70daed (diff)
Added by Tomer Brisker 4 months ago

Fixes #32843 - Don't mock sprintf, n__() in js tests

`sprintf` should return an interpolated string, not the original
formatting string. `n__()` should return the correct string for
singular/plural.

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8611 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.0.0 added

#3 Updated by Tomer Brisker 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF