Project

General

Profile

Refactor #32860

trigger toast notification from the root of the app

Added by Ron Lavi 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Toasts were triggered only from pages that used the PageLayout component, but now they will be triggered directly from the root of the app.


Subtasks

Refactor #32871: Remove consumers of Foreman context for toast alerts handlingNew

Related issues

Related to foreman-tasks - Refactor #33065: remove deprecated <%= notifications %>Closed

Associated revisions

Revision 12e53a9b (diff)
Added by Ron Lavi 4 months ago

Fixes #32860 - move toast list to app's root (#8618)

Toasts were triggered only from pages that used the PageLayout component,
or that used the `notifications` helper. Now they will always be triggered directly
from the root of the app.
Deprecated the `notifications` method so toast won't appear twice in pages
that used it for showing the toast notifications.
Remove the toasts from the foreman context, since toast notification don't
need to be accessed from other components anymore.

Revision 328d925c (diff)
Added by Maria Agaphontzev 3 months ago

Refs #32860 - dont put notification deprecation in the html

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8618 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 3.0.0 added

#3 Updated by Ron Lavi 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8682 added

#5 Updated by Maria Agaphontzev 3 months ago

Also available in: Atom PDF