Project

General

Profile

Refactor #32892

Create proper HttpUrl validator

Added by Ondřej Ezr about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
Rails
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8623
Fixed in Releases:
3.1.0
Found in Releases:

Description

We only have a module that has the validation method, but it would be helpful to expose proper http url validator.

Related issues

Related to Foreman - Refactor #32893: Use new DSL to define General settingsClosed

Associated revisions

Revision 89bd9b02 (diff)
Added by Ondřej Ezr 12 months ago

Fixes #32892 - add rails URL validator

We only exposed module implementing the URL validation, we should
provide a proper HTTP URL attributes validation.

This is much more convenient way to expose validations to new setting
DSL, so the only user of this validation `http_proxy` setting
is a cause for this change.

History

#1 Updated by Ondřej Ezr about 1 year ago

#2 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8623 added

#3 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#4 Updated by Ondřej Ezr about 1 year ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)

#5 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#6 Updated by Ondřej Ezr about 1 year ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)

#7 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#8 Updated by Ondřej Ezr about 1 year ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)

#9 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/8624 added

#10 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 3.1.0 added

#11 Updated by Ondřej Ezr 12 months ago

  • Status changed from Ready For Testing to Closed

#12 Updated by Ondřej Ezr 9 months ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/8624)

Also available in: Atom PDF