Project

General

Profile

Actions

Bug #33049

closed

Make name_column helper defensive with displaying statuses

Added by Tomer Brisker over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Inventory
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

While this shouldn't occur, if for some reason a host status has no type column the name_column helper will cause the page to fail loading with

 
Backtrace for 'comparison of String with nil failed' error (ActionView::Template::Error): comparison of String with nil failed
 | /usr/share/foreman/app/helpers/hosts_helper.rb:97:in `sort_by'
 | /usr/share/foreman/app/helpers/hosts_helper.rb:97:in `name_column'
...

We can avoid this failure easily by being more defensive in our code.

Actions #1

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8675 added
Actions #2

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.0.0 added
Actions #3

Updated by Tomer Brisker over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Tomer Brisker over 2 years ago

  • Fixed in Releases 2.5.3 added
Actions

Also available in: Atom PDF