Bug #33049
Make name_column helper defensive with displaying statuses
Description
While this shouldn't occur, if for some reason a host status has no type column the name_column helper will cause the page to fail loading with
Backtrace for 'comparison of String with nil failed' error (ActionView::Template::Error): comparison of String with nil failed | /usr/share/foreman/app/helpers/hosts_helper.rb:97:in `sort_by' | /usr/share/foreman/app/helpers/hosts_helper.rb:97:in `name_column' ...
We can avoid this failure easily by being more defensive in our code.
Associated revisions
History
#1
Updated by The Foreman Bot over 1 year ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8675 added
#2
Updated by The Foreman Bot over 1 year ago
- Fixed in Releases 3.0.0 added
#3
Updated by Tomer Brisker over 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|29aceca876c8434adb51cc2791e2b3c230bfb6ed.
#4
Updated by Tomer Brisker over 1 year ago
- Fixed in Releases 2.5.3 added
Fixes #33049 - Properly handle missing status type (#8675)
While this shouldn't occur, it appears in some edge cases a status might
be created with no type property. In that case we should not display the
status and not try to sort on it.