Bug #33089
closedDon't store plugin_prefix (and hammer_plugin_prefix) in answers
Description
Today, we expose plugin_prefix and hammer_plugin_prefix as params in puppet-foreman, which means these get stored as answers.
However, this means that one can't restore a backup from a different OS (like from EL7 on EL8), as the prefix changes (tfm-rubygem → rubygem).
I think that users rarely (read: never) have to override our automatic detection of the prefix, so we should move that out of params (and answers).
For the rare case of a user needing to override this, we shall allow that via an "foreman::globals" class, that can be overriden via hiera.
See https://github.com/theforeman/puppet-foreman_proxy/commit/935d45ab53e59fa5424a60eb54b29ccf6b666313 for an related example in puppet-foreman_proxy
Updated by The Foreman Bot over 3 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/puppet-foreman/pull/974 added
Updated by Evgeni Golov over 3 years ago
- Related to Bug #33106: Move more variables from in puppet-foreman to globals.pp added
Updated by Evgeni Golov over 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset puppet-foreman|08254ece967e3dc9874027477dfe209e6b458f49.
Updated by Amit Upadhye over 3 years ago
- Category set to Foreman modules
- Target version set to 3.0.0