Project

General

Profile

Bug #33089

Don't store plugin_prefix (and hammer_plugin_prefix) in answers

Added by Evgeni Golov 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Foreman modules
Target version:
Difficulty:
Triaged:
No
Bugzilla link:

Description

Today, we expose plugin_prefix and hammer_plugin_prefix as params in puppet-foreman, which means these get stored as answers.
However, this means that one can't restore a backup from a different OS (like from EL7 on EL8), as the prefix changes (tfm-rubygem → rubygem).

I think that users rarely (read: never) have to override our automatic detection of the prefix, so we should move that out of params (and answers).
For the rare case of a user needing to override this, we shall allow that via an "foreman::globals" class, that can be overriden via hiera.

See https://github.com/theforeman/puppet-foreman_proxy/commit/935d45ab53e59fa5424a60eb54b29ccf6b666313 for an related example in puppet-foreman_proxy


Related issues

Related to Installer - Bug #33106: Move more variables from in puppet-foreman to globals.ppClosed

Associated revisions

Revision 08254ece (diff)
Added by Evgeni Golov 3 months ago

Fixes #33089 - move (hammer_)plugin_prefix to globals

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-foreman/pull/974 added

#2 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.0.0 added

#3 Updated by Evgeni Golov 3 months ago

  • Related to Bug #33106: Move more variables from in puppet-foreman to globals.pp added

#4 Updated by Evgeni Golov 3 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Amit Upadhye 3 months ago

  • Target version set to 3.0.0
  • Category set to Foreman modules

Also available in: Atom PDF