Project

General

Profile

Bug #33121

Hammer --setup-insights false | no|0 is not working

Added by Leos Stejskal 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Leos Stejskal
Category:
Host registration
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
1978697
Pull request:
https://github.com/theforeman/foreman/pull/8707, https://github.com/theforeman/foreman/pull/8690
Fixed in Releases:
2.5.3, 3.0.0
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1978697

Description of problem:
[global registration] [hammer] - hammer --setup-insights false | no|0 is not working

Version-Release number of selected component (if applicable):
Satellite 6.10 Snap 7

How reproducible:
always

Steps to Reproduce:
try commands

hammer> host-registration generate-command --activation-keys RHEL8_Content_Activation_Key --packages mlocate --force true --setup-insights 0

hammer> host-registration generate-command --activation-keys RHEL8_Content_Activation_Key --packages mlocate --force true --setup-insights false

hammer> host-registration generate-command --activation-keys RHEL8_Content_Activation_Key --packages mlocate --force true --setup-insights no

Actual results:
setup-insights is still running and install the insights package

Expected results:
setup-insights should not run and do not install insights package as --setup-insights is false

Additional info:

Associated revisions

Revision eb03be92 (diff)
Added by Stejskal Leos 10 months ago

Fixes #33121 - Registration command API & params with false values

Registration API for generating registration command
incorrectly ignores parameters with `false` boolean value.

History

#1 Updated by Leos Stejskal 10 months ago

  • Assignee set to Leos Stejskal
  • Category set to Host registration
  • Subject changed from [global registration] [hammer] - hammer --setup-insights false | no|0 is not working to Hammer --setup-insights false | no|0 is not working

#2 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8690 added

#3 Updated by The Foreman Bot 10 months ago

  • Fixed in Releases 3.0.0 added

#4 Updated by Anonymous 10 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8707 added

#6 Updated by Tomer Brisker 10 months ago

  • Fixed in Releases 2.5.3 added

Also available in: Atom PDF