Project

General

Profile

Refactor #33122

Introduce skip pattern for ACL tests

Added by Ondřej Ezr about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

There are some routes added during the test suit, and if the ACL tests run after those dummy routes are added, the ACL obviously fails for them.

We should skip such dummy test routes (or remove them once used, but it is much harder in Rails, once the path is defined).

Associated revisions

Revision b29f53dd (diff)
Added by Ondřej Ezr 12 months ago

Fixes #33122 - Introduce skip pattern for ACL test

The ACL tests are testing all the routes, but if some test previous to
ACL tests add some routes, it fails as such dummy test routes do not
have proper perms. We need to skip such paths in tests as currently we
rely on order of test run.

History

#1 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8674 added

#2 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 3.1.0 added

#3 Updated by Ondřej Ezr 12 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 12 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8752 added

Also available in: Atom PDF