Project

General

Profile

Feature #33191

Support automatic reinstallation of puppet-agent-oauth on Debian

Added by Ewoud Kohl van Wijngaarden 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
foreman-installer script
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:

Description

Since #29097 foreman-installer has automatically reinstalled puppet-agent-oauth on RPMs. This is needed when the Ruby version of Puppet's AIO package has changed. While that typically only happens on a major version upgrade, it's great for users to have it automated. Especially with Foreman 3.0 adding support for Puppet 7.

https://github.com/theforeman/foreman-installer/pull/641 started this effort already.


Related issues

Related to Installer - Bug #29097: Installer prints out puppet-agent-oauth on most runsClosed

Associated revisions

Revision 567172b6 (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Fixes #33191 - Debian puppet-agent-oauth reinstall support

This has been supported for a while on RPM-based distros. This adds it
on Debian.

It also changes it to log an error on noop that it detected an incorrect
situation.

Credits to Tim Eilers for the specific dpkg/apt commands. This PR takes
a bit different implementation approach by also looking at facts. This
should save some useless command executions on both platforms.

Revision 82a4e9ec (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Refs #33191 - Use symbols for facts

In 567172b6411ed9d0731614fd29455e8b7877ccd0 facts were incorrectly using
strings while it should use symbols.

It also adds a debug line to make it easier to follow what happened.

Fixes: 567172b6411ed9d0731614fd29455e8b7877ccd0

History

#1 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Related to Bug #29097: Installer prints out puppet-agent-oauth on most runs added

#2 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/706 added

#3 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.0.0 added

#4 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/708 added

Also available in: Atom PDF