Refactor #33225: Change the way an option is checked for deprecation - Hammer CLI - Foreman

Actions

Copy link

Refactor #33225

closed

Change the way an option is checked for deprecation

Added by Oleh Fedorenko over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Oleh Fedorenko

Category:

Hammer core

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/hammer-cli/pull/351

Team Backlog:

Fixed in Releases:

hammer-cli-3.1.0

Found in Releases:

In Kanboard:

Red Hat JIRA:

Description

Currently we check whether we need to show a deprecation warning for an option through #handles? method [1]. This has a side-effect: whenever we call #find_option, internally it uses #handles? method, so whenever we're searching for an option we will print a deprecation warning if the option has one.

[1] - https://github.com/theforeman/hammer-cli/blob/819023cca20eb8ec1853dd5f901e3e2d0dc0a948/lib/hammer_cli/options/option_definition.rb#L53-L61