Project

General

Profile

Actions

Refactor #33231

closed

Update discovery_doc_url to use the new links controller

Added by Shimon Shtein over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Currently discovery_doc_url (https://github.com/theforeman/foreman_discovery/blob/893e02b52cac0475dd135451a4167d62bdf93878/app/helpers/discovered_hosts_helper.rb#L101) has the link hard coded.

Better way is to use external_link_path helper, similar to https://github.com/theforeman/foreman_azure_rm/pull/111/files. This way the branding would be more straightforward.

Actions #1

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman_discovery/pull/550 added
Actions #2

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases Discovery Plugin 16.0 added
Actions #3

Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF