Project

General

Profile

Refactor #33231

Update discovery_doc_url to use the new links controller

Added by Shimon Shtein over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
-
Target version:
Discovery Plugin 16.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_discovery/pull/550
Fixed in Releases:
Discovery Plugin 16.0
Found in Releases:
Red Hat JIRA:

Description

Currently discovery_doc_url (https://github.com/theforeman/foreman_discovery/blob/893e02b52cac0475dd135451a4167d62bdf93878/app/helpers/discovered_hosts_helper.rb#L101) has the link hard coded.

Better way is to use external_link_path helper, similar to https://github.com/theforeman/foreman_azure_rm/pull/111/files. This way the branding would be more straightforward.

Associated revisions

Revision b25a42fd (diff)
Added by Lukas Zapletal over 1 year ago

Fixes #33231 - update documentation link helper

History

#1 Updated by The Foreman Bot over 1 year ago

  • Assignee set to Lukas Zapletal
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/550 added

#2 Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases Discovery Plugin 16.0 added

#3 Updated by Anonymous over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF