Project

General

Profile

Bug #33238

[SAT-1790] Extend TableWrapper and MainTable to allow using PF TableComposable

Added by Jeremy Lenz 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

https://patternfly-react.surge.sh/components/table#composable-basic

Let's start all our tables off on the right foot.

  • no more formatters
  • no more mixed JSX and logic
  • no more guessing what your markup is going to look like, or looking in 4 different files
  • no more 'rows' and 'cells' props
  • keep data, logic, and markup neatly separate and organized
  • that much easier to get started and probably cause less bugs

This work will consist of

  • add a 'composable' prop to <TableWrapper>
  • if composable prop is passed, MainTable returns <TableComposable> instead of <Table> and doesn't accept rows or cells props-- so you can do either <TableWrapper rows={...} cells={...} /> or <TableWrapper composable > ... </TableWrapper>
Benefits
  • all of the TableComposable benefits listed above
  • we can reuse the pagination and search parts of TableWrapper

Associated revisions

Revision 46d3cb14 (diff)
Added by Jeremy Lenz 9 months ago

Fixes #33238 - Extend TableWrapper and MainTable (#9550)

to allow using PF TableComposable
Refactor ContentViewHistories to use composable table
update babel parser
add class for pf3 table overflow auto

History

#1 Updated by Jonathon Turel 9 months ago

  • Triaged changed from No to Yes
  • Target version changed from Katello 4.2.0 to Katello 4.3.0

#2 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9550 added

#3 Updated by The Foreman Bot 9 months ago

  • Fixed in Releases Katello 4.3.0 added

#4 Updated by Jeremy Lenz 9 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF