Project

General

Profile

Bug #33276

Updating per_page on table sends the page into infinite loops

Added by Samir Jha 2 months ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

To reproduce:

On any page of CV UI with a table, update pagination per_page to a value of 5.
The table keeps refreshing between the new perPage value and the default value.

Associated revisions

Revision fbdd242a (diff)
Added by Jeremy Lenz 6 days ago

Fixes #33276 - Improve TableWrapper change tracking for search & pagination (#9727)

  • Fixes #33276 - Improve TableWrapper logic & track activeFilters

History

#1 Updated by Jeremy Lenz 2 months ago

<jeremylenz> We need to be sure that if the user has changed the perPage value in the dropdown, we no longer care about what's in the Setting.
<adewar> indeed
<jeremylenz> so we could maybe useRef and set a flag
<jeremylenz> and check that flag inside onPaginationUpdate
<jeremylenz> sorry, check that flag right after we set our consts
<jeremylenz> and not use Foreman settings if the user has already set a perPage
<jeremylenz> this may not be fully thought out yet, but i do think we need some sort of decision to use or not use foremanPerPage
<jeremylenz> and don't just use it blindly as a fallback like we're doing
<jeremylenz> we should be checking it once and only once
<jeremylenz> and thereafter we only care about what the user has selected in the dropdown

#2 Updated by The Foreman Bot 11 days ago

  • Assignee set to Jeremy Lenz
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/9727 added

#3 Updated by The Foreman Bot 6 days ago

  • Fixed in Releases Katello 4.3.0 added

#4 Updated by Jeremy Lenz 6 days ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF