Project

General

Profile

Bug #33277

Change Puma defaults to match recommendations from Puma documentation

Added by Eric Helms 2 months ago. Updated 12 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Foreman modules
Target version:

Associated revisions

Revision 533c1f3b (diff)
Added by Eric Helms 2 months ago

Fixes #33277: Change Puma default workers to 1.5 * CPU, max threads to 5

The Puma documentation recommends for CRuby based installations to
start with number of CPUs times 1.5 for workers and defaults to a maxium
of 5 threads when using CRuby.
The previous maximum threads of 16 was based on an incorrect reading
of the Puma documentation and is only the default on non-CRuby Ruby.

Revision 4c129efe (diff)
Added by Eric Helms 2 months ago

Refs #33277: Unset foreman_service_puma_workers and foreman_service_puma_threads_max if set to default value

This resets the foreman_server_puma_workers value to pick up the
newest default which is undef. The change from https://github.com/theforeman/puppet-foreman/pull/986
makes the default a dynamically calculated value that should
provide better out of the box experience for users.

This resets the value of foreman_service_puma_threads_max to the new
default value coming from puppet-foreman of 5. The original default of
16 has been determined to likely be too high for Ruby MRI based installations
and resetting to the recommended default by Puma should result in less
wasted resources. Users can opt to increase this value based on
their environments.

History

#1 Updated by The Foreman Bot 2 months ago

  • Assignee set to Eric Helms
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-foreman/pull/986 added

#2 Updated by The Foreman Bot 2 months ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/714 added

#3 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 3.1.0 added

#4 Updated by Ewoud Kohl van Wijngaarden 2 months ago

  • Triaged changed from No to Yes
  • Target version set to 3.0.0
  • Category set to Foreman modules

#5 Updated by Eric Helms 2 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Eric Helms about 2 months ago

  • Bugzilla link set to 1998291

#7 Updated by Ewoud Kohl van Wijngaarden about 2 months ago

  • Fixed in Releases 3.0.0 added
  • Fixed in Releases deleted (3.1.0)

#8 Updated by Lukas Zapletal 12 days ago

Just for the record, Red Hat Performance team conducted testing of Satellite 6.10 and their recommended value is 16 threads for all t-shirt sizes. So values higher than 5 are probably relevant.

Also available in: Atom PDF