Bug #33319
don't run npm-fix-foreman-stories.sh on every npm install
Pull request:
Fixed in Releases:
Found in Releases:
Description
Right now, we run npm-fix-foreman-stories.sh in postinstall, so on every "npm install" in Foreman, this gets executed and pulls in thousands of deps.
The script guards by $NODE_ENV != "production", but when building assets for packaging, we don't set NODE_ENV to "production" (probably because we need devDependencies actually installed as it contains webpack etc?)
So my questions would be:
1. can we just move npm-fix-foreman-stories.sh to a step that is not automatically executed on every "npm i"?
2. should we run package builds with NODE_ENV=production?
3. what about CI? are storybooks needed there? my gut is saying no?
Related issues
Associated revisions
History
#1
Updated by Evgeni Golov 9 months ago
- Related to Bug #33317: better differentiate between build, develop and test dependencies for JavaScript added
#2
Updated by The Foreman Bot 9 months ago
- Assignee set to Evgeni Golov
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8730 added
#3
Updated by The Foreman Bot 9 months ago
- Fixed in Releases 3.1.0 added
#4
Updated by Evgeni Golov 9 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|2c96294a124d5f6e13d48fc1841fb8441a648e18.
#5
Updated by The Foreman Bot 9 months ago
- Pull request https://github.com/theforeman/foreman/pull/8736 added
#6
Updated by Evgeni Golov 9 months ago
- Fixed in Releases 3.0.0 added
- Fixed in Releases deleted (
3.1.0)
Fixes #33319 - don't run fix-stories on every postinstall