Project

General

Profile

Bug #33319

don't run npm-fix-foreman-stories.sh on every npm install

Added by Evgeni Golov 2 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Right now, we run npm-fix-foreman-stories.sh in postinstall, so on every "npm install" in Foreman, this gets executed and pulls in thousands of deps.

The script guards by $NODE_ENV != "production", but when building assets for packaging, we don't set NODE_ENV to "production" (probably because we need devDependencies actually installed as it contains webpack etc?)

So my questions would be:
1. can we just move npm-fix-foreman-stories.sh to a step that is not automatically executed on every "npm i"?
2. should we run package builds with NODE_ENV=production?
3. what about CI? are storybooks needed there? my gut is saying no?


Related issues

Related to Foreman - Bug #33317: better differentiate between build, develop and test dependencies for JavaScriptNew

Associated revisions

Revision 2c96294a (diff)
Added by Evgeni Golov 2 months ago

Fixes #33319 - don't run fix-stories on every postinstall

History

#1 Updated by Evgeni Golov 2 months ago

  • Related to Bug #33317: better differentiate between build, develop and test dependencies for JavaScript added

#2 Updated by The Foreman Bot 2 months ago

  • Assignee set to Evgeni Golov
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8730 added

#3 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 3.1.0 added

#4 Updated by Evgeni Golov 2 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8736 added

#6 Updated by Evgeni Golov 2 months ago

  • Fixed in Releases 3.0.0 added
  • Fixed in Releases deleted (3.1.0)

Also available in: Atom PDF