Bug #33393: custom confirm modal is broken - Katello - Foreman

Bug #33393

custom confirm modal is broken

Added by Ron Lavi 9 months ago. Updated 9 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

-

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/9601

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

After core confirm modal got merged,
the katello override of rails UJS fails in https://github.com/Katello/katello/blob/master/app/assets/javascripts/katello/common/katello.js#L105

Associated revisions

Revision deff6f1d (diff)
Added by Ron Lavi 9 months ago

Fixes #33393 - remove customConfirm for .erb

Foreman also overrides the jQuery UJS confirm with a PF4 confirm modal

History

#1 Updated by The Foreman Bot 9 months ago

Status changed from New to Ready For Testing
Pull request https://github.com/Katello/katello/pull/9601 added

#2 Updated by Justin Sherrill 9 months ago

Triaged changed from No to Yes
Target version set to Katello 4.3.0

#3 Updated by The Foreman Bot 9 months ago

Fixed in Releases Katello 4.3.0 added

#4 Updated by Ron Lavi 9 months ago

Status changed from Ready For Testing to Closed

Applied in changeset katello|deff6f1d9acc85d2e431d1adfc7916a3c4cf9708.

Also available in: Atom PDF