Project

General

Profile

Actions
Copy link

Refactor #33395

closed

If/else statement have equal code

Added by Maxim Petukhov about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Maxim Petukhov
Category:
-
Target version:
Katello 4.3.0
Branch:
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/9604
Fixed in Releases:
Katello 4.3.0
Found in Releases:
Red Hat JIRA:

Description

in app/views/overrides/activation_keys/_host_synced_content_select.html.erb
if/else statement have equal code:

if using_hostgroups_page?
    select_tag ks_repo_select_id,  view_to_options(kickstart_options, kickstart_repo_id, blank_or_inherit_with_id(f, :kickstart_repository)), :data => {"spinner_path" => spinner_path, "kickstart-repository-id" => kickstart_repo_id},
               :class => 'form-control',  :name => ks_repo_select_name, :disabled => kickstart_options.empty?
  else
    select_tag ks_repo_select_id,  view_to_options(kickstart_options, kickstart_repo_id, blank_or_inherit_with_id(f, :kickstart_repository)), :data => {"spinner_path" => spinner_path, "kickstart-repository-id" => kickstart_repo_id}, :class => 'form-control',  :name => ks_repo_select_name, :disabled => kickstart_options.empty?
  end

so, i think if/else statement is unnecessary

Actions
Copy link

Also available in: Atom PDF