Project

General

Profile

Refactor #33416

Simplify ForemanSwitcher

Added by Tomer Brisker over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
JavaScript stack
Target version:
3.1.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8760
Fixed in Releases:
3.1.0
Found in Releases:
Red Hat JIRA:

Associated revisions

Revision 751cf6c3 (diff)
Added by Tomer Brisker over 1 year ago

Fixes #33416 - Flatten ForemanSwitcher

Revision 3374b76d (diff)
Added by Tomer Brisker over 1 year ago

Refs #33416 - Call fallbackRoute directly

No need to go through renderRoute to render the fallback route (which
triggers a full page reload)

Revision dcd30154 (diff)
Added by Tomer Brisker over 1 year ago

Refs #33416 - Remove beforeRenderingCallback from renderRoute

The only place that used it was the fallback route, which is now called
directly.

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8760 added

#2 Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.2.0 added

#3 Updated by Tomer Brisker over 1 year ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Fixed in Releases 3.1.0 added
  • Fixed in Releases deleted (3.2.0)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/8760)

#5 Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Triaged changed from No to Yes
  • Target version set to 3.1.0
  • Fixed in Releases deleted (3.1.0)
  • Pull request https://github.com/theforeman/foreman/pull/8760 added

#6 Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Fixed in Releases 3.1.0 added

Also available in: Atom PDF