Project

General

Profile

Bug #33514

Toast type in errorToast is incorrect

Added by Jeremy Lenz 11 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When using API middleware's errorToast option, the action dispatched has a type 'error' which is incorrect. This results in a console warning:

Toast notification type 'error' is invalid. Please use one of the following types: success,danger,warning,info,default

It transforms the error to the 'danger' type, but still displays the warning. It should be 'danger' from the beginning to avoid the console warning.

Associated revisions

Revision 335623c3 (diff)
Added by Jeremy Lenz 11 months ago

Fixes #33514 - correct errorToast type

History

#1 Updated by The Foreman Bot 11 months ago

  • Assignee set to Jeremy Lenz
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8783 added

#2 Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 3.1.0 added

#3 Updated by Jeremy Lenz 11 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Amit Upadhye 9 months ago

  • Category set to JavaScript stack

#5 Updated by Ondřej Ezr 9 months ago

  • Fixed in Releases 3.0.2 added

Also available in: Atom PDF