Project

General

Custom queries

Profile

Actions
Copy link

Bug #33514

closed

Toast type in errorToast is incorrect

Added by Jeremy Lenz almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeremy Lenz
Category:
JavaScript stack
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8783
Fixed in Releases:
3.0.2, 3.1.0
Found in Releases:
Red Hat JIRA:

Description

When using API middleware's errorToast option, the action dispatched has a type 'error' which is incorrect. This results in a console warning:

Toast notification type 'error' is invalid. Please use one of the following types: success,danger,warning,info,default

It transforms the error to the 'danger' type, but still displays the warning. It should be 'danger' from the beginning to avoid the console warning.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Jeremy Lenz
  • Pull request https://github.com/theforeman/foreman/pull/8783 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 3.1.0 added
Actions
Copy link
 #3

Updated by Jeremy Lenz almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by Amit Upadhye over 3 years ago

  • Category set to JavaScript stack
Actions
Copy link
 #5

Updated by Ondřej Ezr over 3 years ago

  • Fixed in Releases 3.0.2 added
Actions
Copy link

Also available in: Atom PDF