Project

General

Profile

Actions

Bug #33647

closed

GraphQL response should return valid attribute values

Added by Ondřej Pražák over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
API
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

When we are updating models via GraphQL, we assign new attribute values to the model and save (BaseMutation#save_object).
If there are validation errors, the model with invalid attribute values is used for response. This is causing problems in UI with as Apollo detects a change in an attribute and places the new (invalid) value into its cache. To leverage Apollo's automatic cache updates, we should return the persisted value, not the assigned and invalid.

Steps to reproduce:

variables = { id: model_global_id, name: '' }

mutation UpdateModelMutation($id: ID!, $name: String) {
  updateModel(input: { id: $id, name: $name }) {
    model {
      id
      name
    }
    errors {
      path
      message
    }
  }
}

Expected Result:

{
  updateModel {
    model {
      id: 'very_long_global_id',
      name: 'My model'
    },
    errors: [{
     path: ["attributes", "name"],
     message: "can't be blank" 
   }]
  }
}

Actual Result:

{
  updateModel {
    model {
      id: 'very_long_global_id',
      name: ''
    },
    errors: [{
     path: ["attributes", "name"],
     message: "can't be blank" 
   }]
  }
}
Actions #1

Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ondřej Pražák
  • Pull request https://github.com/theforeman/foreman/pull/8819 added
Actions #2

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.1.0 added
Actions #3

Updated by Ondřej Pražák over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Amit Upadhye over 2 years ago

  • Category set to API
Actions

Also available in: Atom PDF