Project

General

Profile

Support #33649

Add Github action that watches when we change dependencies

Added by Lucy Fu 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Github has a feature where you can add a CODEOWNERS file and it will require a review from people or teams you specify, any time certain files have changed.

Foreman uses this to require reviews from @theforeman/packaging any time package.json has changed (or, any other files that would break packaging). See https://github.com/theforeman/foreman/blob/develop/.github/CODEOWNERS#L4

However, Katello can't use this because "The people you choose as code owners must have write permissions for the repository."

As an alternate solution, we should look into a Github action for Katello that comments on PR's-- maybe tag packaging if the PR changes one of those files.

Associated revisions

Revision a19f0c29 (diff)
Added by Lucy Fu 7 months ago

Fixes #33649 - add github action labeler

History

#1 Updated by The Foreman Bot 7 months ago

  • Fixed in Releases Katello 4.3.0 added

#2 Updated by Lucy Fu 7 months ago

  • Status changed from New to Closed

#3 Updated by Andrew Dewar 7 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 4.3.0

Also available in: Atom PDF