Project

General

Profile

Refactor #33690

Refactor ToastsList to use slice pattern

Added by Tomer Brisker 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Right now the ToastsList component has logic scattered around in multiple places. We can refactor it to use the slice pattern and clean up a lot of boilerplate.


Related issues

Related to foreman-tasks - Bug #34065: Stop using deprecated redux toast actionsClosed
Related to OpenSCAP - Refactor #34069: Stop using deprecated redux toast actionsClosed
Related to Katello - Refactor #34071: Stop using deprecated redux toast actionsClosed

Associated revisions

Revision 3300679a (diff)
Added by Tomer Brisker 3 months ago

Fixes #33690 - Unify toast notification logic in one component

Instead of having the actions and reducers separate from the actual
component, this refactor leverages the slice pattern to unify all of the
logic and remove a lot of boilerplate.

Revision cf0540dd (diff)
Added by Tomer Brisker 3 months ago

Refs #33690 - replace uuid with nanoid for toast key

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8840 added

#2 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 3.1.0 added

#3 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/8860 added

#4 Updated by Tomer Brisker 3 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Tomer Brisker about 2 months ago

  • Related to Bug #34065: Stop using deprecated redux toast actions added

#6 Updated by Oleh Fedorenko about 2 months ago

  • Related to Refactor #34069: Stop using deprecated redux toast actions added

#7 Updated by Oleh Fedorenko about 2 months ago

  • Related to Refactor #34071: Stop using deprecated redux toast actions added

Also available in: Atom PDF