Project

General

Profile

Actions
Copy link

Refactor #33784

closed

Drop Ruby pre-2.5 compatibility in Host#parse_ip_address

Added by Ewoud Kohl van Wijngaarden about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Performance
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8875
Fixed in Releases:
3.1.0
Found in Releases:
Red Hat JIRA:

Description

The method has fallback code for Ruby 2.4 and older but Foreman requires Ruby 2.5 or newer so it can be dropped.

I'm unsure about the category, but technically it'll give a (small) performance benefit.

Actions
Copy link
 #1

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/foreman/pull/8875 added
Actions
Copy link
 #2

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases 3.1.0 added
Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF