Project

General

Profile

Refactor #33784

Drop Ruby pre-2.5 compatibility in Host#parse_ip_address

Added by Ewoud Kohl van Wijngaarden 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Performance
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The method has fallback code for Ruby 2.4 and older but Foreman requires Ruby 2.5 or newer so it can be dropped.

I'm unsure about the category, but technically it'll give a (small) performance benefit.

Associated revisions

Revision 6ec75b34 (diff)
Added by Ewoud Kohl van Wijngaarden 10 months ago

Fixes #33784 - Remove Ruby < 2.5 compatibility code

Foreman requires Ruby 2.5 or newer so it can be dropped.

History

#1 Updated by The Foreman Bot 10 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8875 added

#2 Updated by The Foreman Bot 10 months ago

  • Fixed in Releases 3.1.0 added

#3 Updated by Ewoud Kohl van Wijngaarden 10 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF