Project

General

Profile

Feature #338

Don't use MAC address as matching parameter when using "spoof"

Added by Jon Fautley almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Unattended installations
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When using the 'spoof' unattended installation option from a host on the local network, the MAC address (if available) is still used to determine which host profile to render the kickstart for.

This patch ignores the MAC address if using the ?spoof=<ip.addr> option. This is required for our environment, as we don't directly control DHCP/DNS so use the spoof option to obtain the correct kickstart file.

0001-Don-t-use-MAC-address-as-matching-parameter-when-usi.patch 0001-Don-t-use-MAC-address-as-matching-parameter-when-usi.patch 1.08 KB Patch to ignore MAC address when using spoof Jon Fautley, 07/06/2010 01:19 PM

History

#1 Updated by Ohad Levy over 8 years ago

  • Status changed from New to Feedback
  • Assignee changed from Ohad Levy to Jon Fautley

would you consider refactoring the code that if using spoof, it simply doesn't go to that bit of code?
I think it would be cleaner if all of the additional checks will not be performed if we are in spoof mode.

#2 Updated by Ohad Levy over 8 years ago

  • Tracker changed from Bug to Feature

#3 Updated by Ohad Levy over 8 years ago

  • Target version set to 0.2

This seems to me a bit hackish.. I'll try to refactor the logic.... newer patches are welcome :)

#4 Updated by Ohad Levy over 8 years ago

would you mind refactoring the patch along side with the patch for #359?

#5 Updated by Ohad Levy over 8 years ago

additionally, the latest version uses the MAC address if it exists, ignoring the ip address altogether, maybe this solves your original issue?

#6 Updated by Ohad Levy over 8 years ago

  • Target version deleted (0.2)

waiting for feedback...

#7 Updated by Benjamin Papillon over 6 years ago

  • Status changed from Feedback to New
  • Assignee deleted (Jon Fautley)

I'm removing the feedback status so a bored developer can update the patches

#8 Updated by Benjamin Papillon over 6 years ago

  • Status changed from New to Closed

It should be working with 1.1. Please, don't hesitate to reopen the bug if it is not the case!

Also available in: Atom PDF