Project

General

Profile

Bug #33801

Ruby warning: URI.escape is obsolete after the host is provisioned

Added by Tomer Brisker 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
Unattended installations
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1989631

Description of problem:
Aug 3 11:36:29 dhcp-2-205 foreman: /usr/share/foreman/lib/proxy_api/resource.rb:72: warning: URI.escape is obsolete
Aug 3 11:36:30 dhcp-2-205 smart-proxy: 10.1.2.205 - - [03/Aug/2021:11:36:30 EDT] "GET /tftp/serverName HTTP/1.1" 200 26
Aug 3 11:36:30 dhcp-2-205 smart-proxy: - -> /tftp/serverName
Aug 3 11:36:30 dhcp-2-205 foreman: /usr/share/foreman/lib/proxy_api/resource.rb:72: warning: URI.escape is obsolete
Aug 3 11:36:30 dhcp-2-205 smart-proxy: 10.1.2.205 - - [03/Aug/2021:11:36:30 EDT] "GET /tftp/serverName HTTP/1.1" 200 26
Aug 3 11:36:30 dhcp-2-205 smart-proxy: - -> /tftp/serverName
Aug 3 11:36:30 dhcp-2-205 foreman: /usr/share/foreman/lib/proxy_api/resource.rb:72: warning: URI.escape is obsolete
Aug 3 11:36:30 dhcp-2-205 smart-proxy: 10.1.2.205 - - [03/Aug/2021:11:36:30 EDT] "GET /dhcp/10.1.5.72/mac/56:6f:0d:72:07:b3 HTTP/1.1" 200 272
Aug 3 11:36:30 dhcp-2-205 smart-proxy: - -> /dhcp/10.1.5.72/mac/56:6f:0d:72:07:b3
Aug 3 11:36:30 dhcp-2-205 foreman: /usr/share/foreman/lib/proxy_api/resource.rb:72: warning: URI.escape is obsolete
Aug 3 11:36:30 dhcp-2-205 smart-proxy: 10.1.2.205 - - [03/Aug/2021:11:36:30 EDT] "GET /dhcp/10.1.5.72/ip/10.1.5.76 HTTP/1.1" 200 274
Aug 3 11:36:30 dhcp-2-205 smart-proxy: - -> /dhcp/10.1.5.72/ip/10.1.5.76

Version-Release number of selected component (if applicable):
tfm-rubygem-rails-6.0.3.7-1.el7sat.noarch
rh-ruby27-ruby-libs-2.7.3-129.el7.x86_64
rh-ruby27-runtime-2.7-2.el7.x86_64
rh-ruby27-ruby-2.7.3-129.el7.x86_64
foreman-2.5.2-1.el7sat.noarch
satellite-6.10.0-0.5.beta.el7sat.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Provision host using unattended install.
2. See /var/log/messages at the moment when the host reports back to Satellite after it is provisioned

Actual results:
Satellite is using obsolete methods, warnings are generated.

Expected results:
Satellite is not using obsolete methods, no warnings about obsolete methods are present in the logs.

Additional info:
I expect the fix to be not only in the Foreman itself but also in its plugins that use this obsolete method.
BZ1982343 is dealing with the same issue in Katello.

Associated revisions

Revision 35bc5a33 (diff)
Added by Adi Abramovitch 6 months ago

Fixes #33801 - Replace obsolete URI.escape method

History

#1 Updated by Tomer Brisker 7 months ago

  • Difficulty set to trivial

#2 Updated by Adi Abramovitch 7 months ago

  • Assignee set to Adi Abramovitch

#3 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8907 added

#4 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 3.2.0 added

#5 Updated by Adi Abramovitch 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF