Project

General

Profile

Refactor #33987

Tracker #33983: Cleanup core_extensions

Hostmix to use class_methods

Added by Ondřej Ezr about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We do not use the Hostmix properly, we can use class_methods, instead of extending.
That should look much more standard.


Related issues

Related to Foreman - Refactor #33967: Move basic ActiveRecord::Base custom extensions to ApplicationRecordClosed

Associated revisions

Revision e0154af9 (diff)
Added by Ondřej Ezr about 1 year ago

Fixes #33987 - HostMix using Concern properly

ActiveSupport::Concern is supposed to be included and it looks weird to extend a class by it.
We should use `class_methods` to define class methods instead of extending.

History

#1 Updated by Ondřej Ezr about 1 year ago

  • Tracker changed from Tracker to Refactor

#2 Updated by The Foreman Bot about 1 year ago

  • Assignee set to Ondřej Ezr
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8947 added

#3 Updated by Ondřej Ezr about 1 year ago

  • Related to Refactor #33967: Move basic ActiveRecord::Base custom extensions to ApplicationRecord added

#4 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 3.2.0 added

#5 Updated by Ondřej Ezr about 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF