Bug #34064: ParameterFilterTest accidentally modifies Mocha::Mock - Foreman

Bug #34064

ParameterFilterTest accidentally modifies Mocha::Mock

Added by Evgeni Golov 6 months ago. Updated 6 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Evgeni Golov

Category:

Tests

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/8963

Fixed in Releases:

3.2.0

Found in Releases:

Description

$ bundle exec rake test TEST=test/unit/parameter_filter_test.rb TESTOPTS=-v
#<Mocha::Mock:0x0000557bf12cf750>#test_0002_permits plugin-added attributes from blocks = 0.49 s = .
#<Mocha::Mock:0x0000557bf1f22e30>#test_0001_permits plugin-added attribute = 0.04 s = .

Associated revisions

Revision 104493b2 (diff)
Added by Evgeni Golov 6 months ago

Fixes #34064 - don't override magic `klass` variable

when you let(:klass), it somehow touches the `Mocha::Mock` class,
instead of creating a new thing, freaking out Mocha in the process.

before:

$ bundle exec rake test TEST=test/unit/parameter_filter_test.rb TESTOPTS=-v
    #&lt;Mocha::Mock:0x0000557bf12cf750&gt;#test_0002_permits plugin-added attributes from blocks = 0.49 s = .
    #&lt;Mocha::Mock:0x0000557bf1f22e30&gt;#test_0001_permits plugin-added attribute = 0.04 s = .
    …

after:

$ bundle exec rake test TEST=test/unit/parameter_filter_test.rb TESTOPTS=-v
    ParameterFilterTest::with nested object#test_0001_constructs permit() args for nested attribute through second filter 0.52 = .
    ParameterFilterTest::with nested object#test_0002_permits nested attribute through second filter 0.04 = .
    …