Project

General

Profile

Actions
Copy link

Bug #34141

closed

The validate_presence and validate_readable with predicate broken

Added by Ewoud Kohl van Wijngaarden almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Plugins
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/806
Fixed in Releases:
Foreman - 3.2.0
Found in Releases:
Red Hat JIRA:

Description

When using the following code in modern Ruby, it starts to fail:

validate_presence :setting, if: ->(settings) { false }

This causes the if: part to be interpreted as a setting to validate, rather than as a predicate for :setting.

I reproduced this on Smart Proxy 3.2.0-develop with Ruby 3. It looks like there's no test coverage for this use case.

Actions
Copy link
 #1

Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/smart-proxy/pull/806 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 2 years ago

  • Fixed in Releases 3.2.0 added
Actions
Copy link
 #3

Updated by Ewoud Kohl van Wijngaarden almost 2 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by Amit Upadhye over 1 year ago

  • Subject changed from validate_presence and validate_readable with predicate broken to The validate_presence and validate_readable with predicate broken
Actions
Copy link

Also available in: Atom PDF