Project

General

Profile

Feature #34162

Allow calling load_test_settings without settings

Added by Ewoud Kohl van Wijngaarden over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/807
Fixed in Releases:
Foreman - 3.3.0
Found in Releases:
Red Hat JIRA:

Description

In smart_proxy_for_testing there's load_test_settings and is usually called as:

load_test_settings(key: value)

But when you just want defaults, it must suddenly be called as:

load_test_settings({})

Adding a default would solve this.

Associated revisions

Revision 6b75029e (diff)
Added by Ewoud Kohl van Wijngaarden about 1 year ago

Fixes #34162 - Allow calling load_test_settings without settings

This allows loading only the default settings:

Proxy::MyPlugin::Plugin.load_test_settings

Or

Proxy::MyPlugin::Plugin.load_test_settings()

Previously this had to be written as

Proxy::MyPlugin::Plugin.load_test_settings({})

History

#1 Updated by The Foreman Bot over 1 year ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/807 added

#2 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 3.3.0 added

#3 Updated by Ewoud Kohl van Wijngaarden about 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF