Actions
Bug #34172
closedThe placeholder value of "Optional HTTP headers as JSON" contains \n and the label is too long
Difficulty:
Triaged:
Yes
Description
See the placehold of the headers field, the \n should not probably be escaped and the value should be really multiline
Also the label is too long, the information about the ERB should probably be hidden in the "?" icon like everywhere else. Also the same ERB information should be added to other field that supports it (AFAIK the target URL also supports it)
Files
Updated by Oleh Fedorenko about 1 year ago
Let's use this ticket for HTTP headers only. There is https://projects.theforeman.org/issues/36155 for Target URL field.
Updated by Oleh Fedorenko about 1 year ago
- Status changed from New to Assigned
- Assignee set to Oleh Fedorenko
- Triaged changed from No to Yes
Updated by The Foreman Bot about 1 year ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman_webhooks/pull/58 added
Updated by Oleh Fedorenko almost 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman_webhooks|06b4c62d1ba789da941c29c68da2f3a14b314dbf.
Actions