Project

General

Profile

Actions

Bug #34172

closed

The placeholder value of "Optional HTTP headers as JSON" contains \n and the label is too long

Added by Marek Hulán over 2 years ago. Updated almost 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

See the placehold of the headers field, the \n should not probably be escaped and the value should be really multiline

Also the label is too long, the information about the ERB should probably be hidden in the "?" icon like everywhere else. Also the same ERB information should be added to other field that supports it (AFAIK the target URL also supports it)


Files

headers.png View headers.png 26.1 KB Marek Hulán, 12/16/2021 08:17 PM
Actions #1

Updated by Oleh Fedorenko about 1 year ago

Let's use this ticket for HTTP headers only. There is https://projects.theforeman.org/issues/36155 for Target URL field.

Actions #2

Updated by Oleh Fedorenko about 1 year ago

  • Status changed from New to Assigned
  • Assignee set to Oleh Fedorenko
  • Triaged changed from No to Yes
Actions #3

Updated by The Foreman Bot about 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_webhooks/pull/58 added
Actions #4

Updated by Oleh Fedorenko almost 1 year ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF